Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added_NWM_ponded depth #134

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Added_NWM_ponded depth #134

merged 2 commits into from
Sep 12, 2024

Conversation

ajkhattak
Copy link
Contributor

The PR adds NWM_PONDED_DEPTH variable to the BMI variables output list. It represents surface water, stored in the GIUH/NASH_Cascade array, that didn't drain during the current timestep. It will be need for NextGen vars parity with NWM variables.

Additions

  • Added a BMI output variable

Removals

  • None

Changes

  • None

Testing

  1. All existing tests pass and results are unchanged

Checklist

  • PR has an informative and human-readable title
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Reviewers requested with the Reviewers tool ➡️

Copy link
Contributor

@madMatchstick madMatchstick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ajkhattak - I don't see any problems with these updates, at least in terms of functionality. We may have to eventually update the example realization(s) in ngen/data dir?

Do you recommend running any additional local tests/coupling? -thx!

@ajkhattak
Copy link
Contributor Author

@madMatchstick I don't think we need more testing here, this NWM_Ponded_depth will only be needed/used in baseline simulations.

@ajkhattak ajkhattak merged commit 29231c4 into master Sep 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants